Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10081027: Don't register more than one 'connect' event handler per HostTableEntry. Don't create more than one… (Closed)

Created:
8 years, 8 months ago by Jamie
Modified:
8 years, 8 months ago
Reviewers:
simonmorris
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Don't register more than one 'connect' event handler per HostTableEntry. Don't create more than one HostTableEntry for the daemon UI. BUG=121509 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132295

Patch Set 1 #

Patch Set 2 : Fixed JSCompile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M remoting/webapp/host_controller.js View 1 chunk +15 lines, -7 lines 0 comments Download
M remoting/webapp/host_table_entry.js View 1 3 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jamie
ptal
8 years, 8 months ago (2012-04-13 23:12:31 UTC) #1
simonmorris
8 years, 8 months ago (2012-04-13 23:30:25 UTC) #2
On 2012/04/13 23:12:31, Jamie wrote:
> ptal

lgtm

Powered by Google App Engine
This is Rietveld 408576698