Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: ppapi/thunk/ppb_message_loop_api.h

Issue 10081020: PPAPI: Make blocking completion callbacks work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: export AssertLockHeld Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/ppb_layer_compositor_api.h ('k') | ppapi/thunk/ppb_mouse_lock_thunk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/thunk/ppb_message_loop_api.h
diff --git a/ppapi/thunk/ppb_message_loop_api.h b/ppapi/thunk/ppb_message_loop_api.h
index 36f2f1a3a0e00d68294b8ba7c65af293344fd33c..52660cad898a9fd3b40a400b2682cac8514fe1d5 100644
--- a/ppapi/thunk/ppb_message_loop_api.h
+++ b/ppapi/thunk/ppb_message_loop_api.h
@@ -5,7 +5,15 @@
#ifndef PPAPI_THUNK_PPB_MESSAGE_LOOP_API_H_
#define PPAPI_THUNK_PPB_MESSAGE_LOOP_API_H_
+#include "base/memory/ref_counted.h"
+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_completion_callback.h"
+#include "ppapi/c/pp_stdint.h"
+
namespace ppapi {
+
+class TrackedCallback;
+
namespace thunk {
class PPB_MessageLoop_API {
@@ -14,6 +22,10 @@ class PPB_MessageLoop_API {
virtual int32_t AttachToCurrentThread() = 0;
virtual int32_t Run() = 0;
+ // Note: Most interfaces should use scoped_refptr<TrackedCallback>, in order
+ // to track callbacks and support things like blocking or optional callbacks.
+ // In this case, the callback is really just a way to pass a function pointer,
+ // and those options don't make sense.
virtual int32_t PostWork(PP_CompletionCallback callback,
int64_t delay_ms) = 0;
virtual int32_t PostQuit(PP_Bool should_destroy) = 0;
« no previous file with comments | « ppapi/thunk/ppb_layer_compositor_api.h ('k') | ppapi/thunk/ppb_mouse_lock_thunk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698