Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: ppapi/proxy/ppb_instance_proxy.cc

Issue 10081020: PPAPI: Make blocking completion callbacks work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: try again Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppb_instance_proxy.cc
diff --git a/ppapi/proxy/ppb_instance_proxy.cc b/ppapi/proxy/ppb_instance_proxy.cc
index 667a8a217826a5c3c7a07ee6dfcc1d5a9316bb54..6249a1472875fd410121ac1f792c639cbdf32659 100644
--- a/ppapi/proxy/ppb_instance_proxy.cc
+++ b/ppapi/proxy/ppb_instance_proxy.cc
@@ -435,16 +435,13 @@ PP_Bool PPB_Instance_Proxy::SetCursor(PP_Instance instance,
}
int32_t PPB_Instance_Proxy::LockMouse(PP_Instance instance,
- PP_CompletionCallback callback) {
- if (!callback.func)
- return PP_ERROR_BADARGUMENT;
-
+ scoped_refptr<TrackedCallback> callback) {
// Save the mouse callback on the instance data.
InstanceData* data = static_cast<PluginDispatcher*>(dispatcher())->
GetInstanceData(instance);
if (!data)
return PP_ERROR_BADARGUMENT;
- if (data->mouse_lock_callback.func)
+ if (TrackedCallback::IsPending(data->mouse_lock_callback))
return PP_ERROR_INPROGRESS; // Already have a pending callback.
data->mouse_lock_callback = callback;
@@ -639,7 +636,7 @@ void PPB_Instance_Proxy::OnHostMsgLockMouse(PP_Instance instance) {
return;
}
int32_t result = enter.functions()->LockMouse(instance,
- cb.pp_completion_callback());
+ enter.callback());
if (result != PP_OK_COMPLETIONPENDING)
cb.Run(result);
}
@@ -682,8 +679,9 @@ void PPB_Instance_Proxy::OnHostMsgDocumentCanAccessDocument(PP_Instance active,
*result = enter.functions()->DocumentCanAccessDocument(active, target);
}
-void PPB_Instance_Proxy::OnHostMsgGetDocumentURL(PP_Instance instance,
- SerializedVarReturnValue result) {
+void PPB_Instance_Proxy::OnHostMsgGetDocumentURL(
+ PP_Instance instance,
+ SerializedVarReturnValue result) {
EnterInstanceNoLock enter(instance);
if (enter.succeeded()) {
result.Return(dispatcher(),
@@ -756,11 +754,11 @@ void PPB_Instance_Proxy::OnPluginMsgMouseLockComplete(PP_Instance instance,
GetInstanceData(instance);
if (!data)
return; // Instance was probably deleted.
- if (!data->mouse_lock_callback.func) {
+ if (TrackedCallback::IsPending(data->mouse_lock_callback)) {
NOTREACHED();
return;
}
- PP_RunAndClearCompletionCallback(&data->mouse_lock_callback, result);
+ TrackedCallback::ClearAndRun(&(data->mouse_lock_callback), result);
}
void PPB_Instance_Proxy::MouseLockCompleteInHost(int32_t result,

Powered by Google App Engine
This is Rietveld 408576698