Issue 10081009: Add PushAddress(ExternalReference) for X64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10081009: Add PushAddress(ExternalReference) for X64. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add PushAddress(ExternalReference) for X64. R=erik.corry@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=11329

Patch Set 2 : Addressed comment by Erik Corry. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
M	src/x64/macro-assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		3 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

Lgtm https://chromiumcodereview.appspot.com/10081009/diff/1/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://chromiumcodereview.appspot.com/10081009/diff/1/src/x64/macro-assembler-x64.cc#newcode160 src/x64/macro-assembler-x64.cc:160: push(kScratchRegister); If we are emitting debug code we ...

8 years, 8 months ago (2012-04-14 08:37:04 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-16 10:53:55 UTC) #3

Added new patch set. Rebased. Landed.

https://chromiumcodereview.appspot.com/10081009/diff/1/src/x64/macro-assemble...
File src/x64/macro-assembler-x64.cc (right):

https://chromiumcodereview.appspot.com/10081009/diff/1/src/x64/macro-assemble...
src/x64/macro-assembler-x64.cc:160: push(kScratchRegister);
On 2012/04/14 08:37:04, Erik Corry wrote:
> If we are emitting debug code we should zap the scratch reg if we don't use it

Done.

Expand Messages | Collapse Messages

Issue 10081009: Add PushAddress(ExternalReference) for X64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment by Erik Corry. #

Messages