Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 10081005: Merged r11308, r11311, r11313 into trunk branch. (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merged r11308, r11311, r11313 into trunk branch. Fix several ancient presubmit failures. Provide empty default implementation of OutputStream::WriteUint32Chunk to make Webkit V8 bindings compile Fix r11306 to use external references on X64. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11316

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M include/v8.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/arguments.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
8 years, 8 months ago (2012-04-13 12:55:31 UTC) #1
Michael Starzinger
8 years, 8 months ago (2012-04-13 12:59:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698