Set the authorization header when calling an API. Otherwise, no API call will succeed.

Set the authorization header when calling an API. Otherwise, no API call will succeed.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132473

[asargent_no_longer_on_chrome, 2012-04-13 23:39:24]

The code change looks good - can we add a test for this as well?

[Munjal (Google), 2012-04-16 19:27:37]

Added tests. Sorry for the laziness earlier. PTAL.

[jstritar, 2012-04-16 19:30:19]

lgtm thanks!

[jstritar, 2012-04-16 19:30:36]

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
File chrome/common/net/gaia/oauth2_api_call_flow.cc (right):

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
chrome/common/net/gaia/oauth2_api_call_flow.cc:29: static  std::string
MakeAuthorizationHeader(const std::string& auth_token) {
nit: rm extra space

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
chrome/common/net/gaia/oauth2_api_call_flow.cc:32: }
nit:  // namespace

[Munjal (Google), 2012-04-16 19:32:14]

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
File chrome/common/net/gaia/oauth2_api_call_flow.cc (right):

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
chrome/common/net/gaia/oauth2_api_call_flow.cc:29: static  std::string
MakeAuthorizationHeader(const std::string& auth_token) {
On 2012/04/16 19:30:36, jstritar wrote:
> nit: rm extra space

Done.

http://codereview.chromium.org/10080016/diff/4001/chrome/common/net/gaia/oaut...
chrome/common/net/gaia/oauth2_api_call_flow.cc:32: }
On 2012/04/16 19:30:36, jstritar wrote:
> nit:  // namespace

Done.

[asargent_no_longer_on_chrome, 2012-04-16 19:55:33]

lgtm