Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: lib/dom/scripts/generator.py

Issue 10080008: Do not delete DOMStringMap and DOMStringList types from idl database. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added empty DOMStringList implementation. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/dartdomgenerator.py ('k') | lib/dom/src/DOMStringList.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/generator.py
diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py
index e5733dc33e8c99bbd2b1c034550f0033e89dc150..96f90af208bf2276f1df9a74c2053b1345e610b5 100644
--- a/lib/dom/scripts/generator.py
+++ b/lib/dom/scripts/generator.py
@@ -9,6 +9,8 @@ Dart APIs from the IDL database."""
import re
_pure_interfaces = set([
+ 'DOMStringList',
+ 'DOMStringMap',
'ElementTimeControl',
'ElementTraversal',
'MediaQueryListListener',
@@ -543,11 +545,6 @@ _idl_type_registry = {
# TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
# http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
'Flags': PrimitiveIDLTypeInfo('Flags', dart_type='Object'),
- 'List<String>': PrimitiveIDLTypeInfo('DOMStringList', dart_type='List<String>'),
- # TODO: there is no Map<String, String> type in idls. Fix the
- # fremontcut builder and remove this entry.
- 'Map<String, String>': PrimitiveIDLTypeInfo('DOMStringMap', dart_type='Map<String, String>',
- conversion_includes=['DOMStringMap']),
'DOMTimeStamp': PrimitiveIDLTypeInfo('DOMTimeStamp', dart_type='int'),
'object': PrimitiveIDLTypeInfo('object', dart_type='Object', native_type='ScriptValue'),
# TODO(sra): Come up with some meaningful name so that where this appears in
« no previous file with comments | « lib/dom/scripts/dartdomgenerator.py ('k') | lib/dom/src/DOMStringList.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698