Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: lib/dom/src/native_DOMImplementation.dart

Issue 10080008: Do not delete DOMStringMap and DOMStringList types from idl database. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/src/DOMStringMap.dart ('k') | lib/dom/templates/dom/native/dom_public.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/src/native_DOMImplementation.dart
diff --git a/lib/dom/src/native_DOMImplementation.dart b/lib/dom/src/native_DOMImplementation.dart
index aa0a3ccca2aebd3ef3eef8d7bcc8f9f7e0b7c99f..048fedb8494cd4feacc099d979afaadfbde75545 100644
--- a/lib/dom/src/native_DOMImplementation.dart
+++ b/lib/dom/src/native_DOMImplementation.dart
@@ -79,7 +79,7 @@ class LocationCrossFrameImplementation extends DOMWrapperBase implements Locatio
String get typeName() => "Location";
}
-class DOMStringMapImplementation extends DOMWrapperBase implements Map<String, String> {
+class DOMStringMapImplementation extends DOMWrapperBase implements DOMStringMap {
Anton Muhin 2012/04/13 16:46:34 don't you have to add DOMStringListImplementation
podivilov 2012/04/13 16:49:26 Could you please clarify? We need to add DOMString
Anton Muhin 2012/04/13 16:51:18 I don't think it's a good idea to stop removing DO
podivilov 2012/04/13 17:00:53 The problem with it is that we'll have to provide
Anton Muhin 2012/04/13 17:08:56 Whatever you prefer. On 2012/04/13 17:00:53, podi
static DOMStringMapImplementation _createDOMStringMapImplementation() => new DOMStringMapImplementation._createDOMStringMapImplementation();
DOMStringMapImplementation._createDOMStringMapImplementation();
« no previous file with comments | « lib/dom/src/DOMStringMap.dart ('k') | lib/dom/templates/dom/native/dom_public.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698