Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 10080002: cleanup: Use MockXKeyboard in caps_lock_handler_browsertest.cc. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
Reviewers:
Daniel Erat, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, sky
Visibility:
Public.

Description

cleanup: Use MockXKeyboard in caps_lock_handler_browsertest.cc. BUG=None TEST=ran the browser test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132505

Patch Set 1 #

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -52 lines) Patch
M chrome/browser/ui/views/ash/caps_lock_handler_browsertest.cc View 2 chunks +3 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
Daniel, could you take a look?
8 years, 8 months ago (2012-04-16 06:51:56 UTC) #1
Daniel Erat
lgtm
8 years, 8 months ago (2012-04-16 16:17:29 UTC) #2
sky
Rubber stamp LGTM (in case you need one)
8 years, 8 months ago (2012-04-16 17:24:25 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 00:29:38 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698