chrome/browser/resources/options2/password_manager_list.js - Issue 10079024: Normalizes URLs requested for favicons in the password manager dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/password_manager_list.js

Issue 10079024: Normalizes URLs requested for favicons in the password manager dialog. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options2/password_manager_list.js

diff --git a/chrome/browser/resources/options2/password_manager_list.js b/chrome/browser/resources/options2/password_manager_list.js

index acc1af2af61ac613f71ee3a905a878d0c7f10ca5..f3d76a035bbbc0b818433944344dc53e8dbfadc7 100644

--- a/chrome/browser/resources/options2/password_manager_list.js

+++ b/chrome/browser/resources/options2/password_manager_list.js

@@ -38,7 +38,8 @@ cr.define('options.passwordManager', function() {

urlLabel.classList.add('url');

urlLabel.setAttribute('title', this.url);

urlLabel.textContent = this.url;

- urlLabel.style.backgroundImage = url('chrome://favicon/' + this.url);

+ urlLabel.style.backgroundImage =

+ url('chrome://favicon/normalize/' + this.url);

this.contentElement.appendChild(urlLabel);

// The stored username.

@@ -172,7 +173,8 @@ cr.define('options.passwordManager', function() {

urlLabel.classList.add('favicon-cell');

urlLabel.classList.add('weakrtl');

urlLabel.textContent = this.url;

- urlLabel.style.backgroundImage = url('chrome://favicon/' + this.url);

+ urlLabel.style.backgroundImage =

+ url('chrome://favicon/normalize/' + this.url);

this.contentElement.appendChild(urlLabel);

« no previous file with comments | « no previous file | chrome/browser/ui/webui/favicon_source.cc » ('j') | chrome/browser/ui/webui/favicon_source.cc » ('J')