Normalizes URLs requested for favicons in the password manager dialog.

chrome/browser/ui/webui/favicon_source.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/favicon_source.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 40 matching lines @@
 
     if (path.size() > 5 && path.substr(0, 5) == "size/") {
       size_t slash = path.find("/", 5);
       std::string size = path.substr(5, slash - 5);
       int pixel_size = atoi(size.c_str());
       CHECK(pixel_size == 32 || pixel_size == 16) <<
           "only 32x32 and 16x16 icons are supported";
       request_size_map_[request_id] = pixel_size;
       url = GURL(path.substr(slash + 1));
     } else {
+      if (path.size() > 10 && path.substr(0, 10) == "normalize/") {

[Evan Stade, 2012/04/14 00:32:43]

why isn't this normalization just the default?

[Kyle Horimoto, 2012/04/16 19:08:15]

Essentially, any page can have its own favicon (e.g., example.com/a and
example.com/b could have different favicons). Thus, doing this for every favicon
request could result in incorrect favicons. This is a special case because it is
managing passwords for an entire domain (i.e., we store the password for the
domain, not individually for each page on the domain).

[Evan Stade, 2012/04/16 20:45:18]

in this case I would not call it "normalize", but "origin" or something. Also a
brief form of your response would be good to add as a comment.

[Kyle Horimoto, 2012/04/17 21:37:39]

Done.

+        std::string originalUrl = path.substr(10);
+
+        // If the original URL does not specify a scheme (e.g., example.com
+        // instead of http://example.com), add "http://" as a default.
+        if (originalUrl.find("://") == std::string::npos)

[Evan Stade, 2012/04/14 00:32:43]

probably safest to use GURL for this (it has complicated canonicalization
routines). Something like:

if (GURL(originalUrl).scheme().empty())

[Kyle Horimoto, 2012/04/16 19:08:15]

Done.

+          originalUrl = "http://" + originalUrl;
+
+        // Strip the path beyond the top-level domain.
+        url = GURL(originalUrl).GetOrigin();
+      } else {
+        url = GURL(path);
+      }
+
       request_size_map_[request_id] = 16;
-      url = GURL(path);
     }
 
     // Intercept requests for prepopulated pages.
     for (size_t i = 0; i < arraysize(history::kPrepopulatedPages); i++) {
       if (url.spec() ==
           l10n_util::GetStringUTF8(history::kPrepopulatedPages[i].url_id)) {
         request_size_map_.erase(request_id);
         SendResponse(request_id,
             ResourceBundle::GetSharedInstance().LoadDataResourceBytes(
                 history::kPrepopulatedPages[i].favicon_id));
@@ skipping 56 matching lines @@
       default_favicon_ =
           ResourceBundle::GetSharedInstance().LoadDataResourceBytes(
               IDR_DEFAULT_FAVICON);
     }
     bytes = default_favicon_;
   }
   request_size_map_.erase(request_id);
 
   SendResponse(request_id, bytes);
 }