Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10079015: changes to suppress vm failures in windows (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 68f6366a23e9b18ca45fa947f6a14492a5fc3023..20016d19328591a5933cca7ca4e976181f01f40f 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -253,6 +253,21 @@ class TestOutputImpl implements TestOutput {
bool get hasCrashed() {
if (new Platform().operatingSystem() == 'windows') {
+ if (exitCode != 0) {
+ // Suppress some flaky errors that crash the VM.
+ // TODO(sigmund,efortuna): remove this when bug 2124 gets fixed.
+ for (String line in testCase.output.stdout) {
+ if (line.startsWith('Kind:')) {
+ if (!alreadyPrintedWarning) {
+ print("WARNING: VM crashed: $line, exit code: $exitCode. "
+ " This is a fake pass!!");
+ alreadyPrintedWarning = true;
+ }
+ return false;
+ }
+ }
+ }
+
// The VM uses std::abort to terminate on asserts.
// std::abort terminates with exit code 3 on Windows.
if (exitCode == 3) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698