Issue 10079004: Fix r11306 to use external references on X64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10079004: Fix r11306 to use external references on X64. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Erik Corry, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix r11306 to use external references on X64. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11313

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	src/x64/stub-cache-x64.cc	View		4 chunks	+8 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64.cc#newcode1190 src/x64/stub-cache-x64.cc:1190: __ push(kScratchRegister); In the case where the isolate address ...

8 years, 8 months ago (2012-04-13 11:34:52 UTC) #3

Michael Starzinger

8 years, 8 months ago (2012-04-13 11:43:53 UTC) #4

On 2012/04/13 11:34:52, Erik Corry wrote:
>
https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64.cc
> File src/x64/stub-cache-x64.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10079004/diff/1/src/x64/stub-cache-x64...
> src/x64/stub-cache-x64.cc:1190: __ push(kScratchRegister);
> In the case where the isolate address is <4Gbytes the old code was correct and
> faster.  Worth checking for?  A Push(ExternalReference) instruction in the
macro
> assembler that checked for the serializer being active and the address being
> under 4Gbytes could do this.

Yes, actually having a Push(ExternalReference) seems like a very good thing to
have. Good point, I'll implement that in a separate CL.

Expand Messages | Collapse Messages