[File Manager] Hide hover state when using keyboard.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 
 /**
  * FileManager constructor.
  *
@@ skipping 659 matching lines @@
     this.renameInput_.addEventListener(
         'keydown', this.onRenameInputKeyDown_.bind(this));
     this.renameInput_.addEventListener(
         'blur', this.onRenameInputBlur_.bind(this));
 
     this.filenameInput_.addEventListener(
         'keyup', this.onFilenameInputKeyUp_.bind(this));
     this.filenameInput_.addEventListener(
         'focus', this.onFilenameInputFocus_.bind(this));
 
-    var listContainer = this.dialogDom_.querySelector('.list-container');
-    listContainer.addEventListener('keydown', this.onListKeyDown_.bind(this));
-    listContainer.addEventListener('keypress', this.onListKeyPress_.bind(this));
+    this.listContainer_ = this.dialogDom_.querySelector('.list-container');
+    this.listContainer_.addEventListener(
+        'keydown', this.onListKeyDown_.bind(this));
+    this.listContainer_.addEventListener(
+        'keypress', this.onListKeyPress_.bind(this));
+    this.listContainer_.addEventListener(
+        'mousemove', this.onListMouseMove_.bind(this));
+
     this.okButton_.addEventListener('click', this.onOk_.bind(this));
     this.cancelButton_.addEventListener('click', this.onCancel_.bind(this));
 
     this.dialogDom_.querySelector('div.open-sidebar').addEventListener(
         'click', this.onToggleSidebar_.bind(this));
     this.dialogDom_.querySelector('div.open-sidebar').addEventListener(
         'keypress', this.onToggleSidebarPress_.bind(this));
     this.dialogDom_.querySelector('div.close-sidebar').addEventListener(
         'click', this.onToggleSidebar_.bind(this));
     this.dialogDom_.querySelector('div.close-sidebar').addEventListener(
@@ skipping 3579 matching lines @@
           this.onDirectoryAction(this.selection.entries[0]);
         } else if (this.dispatchSelectionAction_()) {
           event.preventDefault();
         }
         break;
 
       case '46':  // Delete.
         handleCommand('delete');
         break;
     }
+
+    switch (util.getKeyModifiers(event) + event.keyIdentifier) {
+      case 'Home':
+      case 'End':
+      case 'Up':

[dgozman, 2012/04/13 12:16:24]

What about Ctrl and Shift when user selects files? I think, we should hide
highlight too.

[Vladislav Kaznacheev, 2012/04/13 12:43:50]

Done.

+      case 'Down':
+      case 'Left':
+      case 'Right':
+        // When navigating with keyboard we hide the distracting mouse hover
+        // highlighting until the user moves the mouse again.
+        this.listContainer_.classList.add('nohover');
+        break;
+    }
   };
 
   /**
    * KeyPress event handler for the div.list-container element.
    */
   FileManager.prototype.onListKeyPress_ = function(event) {
     if (event.srcElement.tagName == 'INPUT') {
       // Ignore keypress handler in the rename input box.
       return;
     }
 
     if (event.ctrlKey || event.metaKey || event.altKey)
       return;
 
     var now = new Date();
     var char = String.fromCharCode(event.charCode).toLowerCase();
     var text = now - this.textSearchState_.date > 1000 ? '' :
         this.textSearchState_.text;
     this.textSearchState_ = {text: text + char, date: now};
 
     this.doTextSearch_();
   };
 
   /**
+   * Mousemove event handler for the div.list-container element.
+   */
+  FileManager.prototype.onListMouseMove_ = function(event) {
+    // The user grabbed the mouse, restore the hover highlighting.
+    this.listContainer_.classList.remove('nohover');
+  };
+
+  /**
    * Performs a 'text search' - selects a first list entry with name
    * starting with entered text (case-insensitive).
    */
   FileManager.prototype.doTextSearch_ = function() {
     var text = this.textSearchState_.text;
     if (!text)
       return;
 
     var dm = this.directoryModel_.fileList;
     for (var index = 0; index < dm.length; ++index) {
@@ skipping 381 matching lines @@
 
     chrome.fileBrowserPrivate.setGDataPreferences(changeInfo);
 
     if (oldValue) {
       event.target.removeAttribute('checked');
     } else {
       event.target.setAttribute('checked', 'checked');
     }
   };
 })();