Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10079002: [File Manager] Hide hover state when using keyboard. (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev
Modified:
8 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[File Manager] Hide hover state when using keyboard. BUG=chromium-os:22836 TEST=Move through the list or grid using arrow keys, observe that the item under the mouse is not highlighted. Move the mouse, observe the hover highlighting. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132178

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 3 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
8 years, 8 months ago (2012-04-13 10:19:00 UTC) #1
Vladislav Kaznacheev
Please review.
8 years, 8 months ago (2012-04-13 10:19:09 UTC) #2
dgozman
LGTM with comment https://chromiumcodereview.appspot.com/10079002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10079002/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode4291 chrome/browser/resources/file_manager/js/file_manager.js:4291: case 'Up': What about Ctrl and ...
8 years, 8 months ago (2012-04-13 12:16:24 UTC) #3
Vladislav Kaznacheev
8 years, 8 months ago (2012-04-13 12:43:50 UTC) #4
https://chromiumcodereview.appspot.com/10079002/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10079002/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:4291: case 'Up':
On 2012/04/13 12:16:24, dgozman wrote:
> What about Ctrl and Shift when user selects files? I think, we should hide
> highlight too.

Done.

Powered by Google App Engine
This is Rietveld 408576698