Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/chromeos/system/statistics_provider.h

Issue 10078017: Added asynchronous notification of readiness to the StatisticsProvider, and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Timeout while waiting for the hardware_class; sample UMA stats Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/system/statistics_provider.h
diff --git a/chrome/browser/chromeos/system/statistics_provider.h b/chrome/browser/chromeos/system/statistics_provider.h
index 1908087826ccb6b91d74b66b56b69ea3cdbde80e..413453a29052f4c543ec237be3467077959a778c 100644
--- a/chrome/browser/chromeos/system/statistics_provider.h
+++ b/chrome/browser/chromeos/system/statistics_provider.h
@@ -8,18 +8,31 @@
#include <string>
+#include "base/callback.h"
+
namespace chromeos {
namespace system {
// This interface provides access to Chrome OS statistics.
class StatisticsProvider {
public:
- // Retrieve the named machine statistic (e.g. "hardware_class").
- // This does not update the statistcs. If the |name| is not set, |result|
- // preserves old value.
+ // Get the machine statistic with a key of |name| (e.g., "hardware_class").
+ // Returns true if the key was found, and data was returned in |result|.
+ // Returns false otherwise, and the contents of |result| are undefined.
+ // This call may block for an arbitrary length of time (waiting for statistics
+ // to load, or a timeout to take place). If this function is called anytime
+ // after WhenReady() has invoked any callback, then this function is
+ // guaranteed not to block.
virtual bool GetMachineStatistic(const std::string& name,
std::string* result) = 0;
+ // Invokes |callback| on the UI loop once the statistics have been loaded.
+ // |callback| is immediately posted to the UI loop if the statistics are
+ // already available. All the statistics are available once |callback| is
+ // invoked, and GetMachineStatistic() can be invoked as many times as
+ // desired without blocking.
+ virtual void WhenReady(const base::Closure& callback) = 0;
+
static StatisticsProvider* GetInstance();
protected:

Powered by Google App Engine
This is Rietveld 408576698