Issue 10078015: Fix includes order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10078015: Fix includes order. (Closed)

Created:
8 years, 8 months ago by alexeif

Modified:
8 years, 8 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix includes order. TBR=mnaganov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11393

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	test/cctest/test-heap-profiler.cc	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

8 years, 8 months ago (2012-04-19 20:02:54 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10078015/diff/1/test/cctest/test-heap-...
File test/cctest/test-heap-profiler.cc (right):

https://chromiumcodereview.appspot.com/10078015/diff/1/test/cctest/test-heap-...
test/cctest/test-heap-profiler.cc:5: #include <ctype.h>
Sorry, didn't spot that in your original CL. "v8.h" is a "project header", thus
it goes after system headers.

Expand Messages | Collapse Messages