Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: tests/standalone/src/io/TestRunnerTest.dart

Issue 10078011: Fix flaky standalone/io/TestRunnerTest, a unit test of the testing framework. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use test_options.dart to make the configurations. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/io/TestRunnerTest.dart
diff --git a/tests/standalone/src/io/TestRunnerTest.dart b/tests/standalone/src/io/TestRunnerTest.dart
index c4eff2c5b95bdf0a9236aa653e247a26108d126b..4163d4923df413962c54c8c132bad06b704f3cb9 100644
--- a/tests/standalone/src/io/TestRunnerTest.dart
+++ b/tests/standalone/src/io/TestRunnerTest.dart
@@ -5,6 +5,7 @@
#import("dart:io");
#import("../../../../tools/testing/dart/test_runner.dart");
#import("../../../../tools/testing/dart/status_file_parser.dart");
+#import("../../../../tools/testing/dart/test_options.dart");
#source("ProcessTestUtil.dart");
class TestController {
@@ -42,8 +43,7 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
test_path = "../tests/standalone/src/${testName}.dart";
}
- var configuration = { 'timeout': 2,
- 'special-command': '' };
+ var configuration = new TestOptionsParser().parse(['--timeout', '2'])[0];
return new TestCase(testName,
[new Command(getDartFileName(),
<String>["--ignore-unrecognized-flags",
@@ -56,12 +56,11 @@ TestCase MakeTestCase(String testName, List<String> expectations) {
void main() {
- var configuration = { 'timeout': 2,
- 'special-command': '' };
new RunningProcess(MakeTestCase("PassTest", [PASS])).start();
new RunningProcess(MakeTestCase("FailTest", [FAIL])).start();
new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT])).start();
+ var configuration = new TestOptionsParser().parse(['--timeout', '10'])[0];
new RunningProcess(new TestCase("CrashTest",
[new Command(getProcessTestFileName(),
const ["0", "0", "1", "1"])],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698