Add an accessible name to the restart button

Add an accessible name to the restart button


R=hashimoto@chromium.org
BUG=chromium-os:29383
TEST=See bug


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133403

[sadrul, 2012-04-19 11:25:38]

style nits

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
File ash/system/tray/tray_views.h (right):

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:62: virtual void
GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
GetAccessibleState should be above OnPaintFocusBorder (since that is the order
in view.h)

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:65: void SetAccessibleName(const string16& name);
This should be in line ~58 (above the overridden methods)

[sadrul, 2012-04-19 11:33:58]

Could you please cleanup tray_settings.cc as well?

http://codereview.chromium.org/10078009/diff/1/ash/system/tray/tray_views.h
File ash/system/tray/tray_views.h (right):

http://codereview.chromium.org/10078009/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:65: void SetAccessibleName(const string16& name);
On 2012/04/19 11:25:38, sadrul wrote:
> This should be in line ~58 (above the overridden methods)

Perhaps just make this public, and add accessible_name() { return
accessible_name_; }

http://codereview.chromium.org/10078009/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:87: // Convenience function for adding an icon and
a label.
Update the comment here (and in 88) that this also sets the accessible-name, and
SetAccessibleName should be used if it needs to be different.

http://codereview.chromium.org/10078009/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:97: void SetAccessibleName(const string16& name);
Remove this.

http://codereview.chromium.org/10078009/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:116: string16 accessible_name_;
And this

[Zachary Kuznia, 2012-04-20 09:26:58]

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
File ash/system/tray/tray_views.h (right):

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:62: virtual void
GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;
On 2012/04/19 11:25:38, sadrul wrote:
> GetAccessibleState should be above OnPaintFocusBorder (since that is the order
> in view.h)

Done.

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:65: void SetAccessibleName(const string16& name);
On 2012/04/19 11:25:38, sadrul wrote:
> This should be in line ~58 (above the overridden methods)

Done.

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:65: void SetAccessibleName(const string16& name);
On 2012/04/19 11:33:58, sadrul wrote:
> On 2012/04/19 11:25:38, sadrul wrote:
> > This should be in line ~58 (above the overridden methods)
> 
> Perhaps just make this public, and add accessible_name() { return
> accessible_name_; }

Done.

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:87: // Convenience function for adding an icon and
a label.
On 2012/04/19 11:33:58, sadrul wrote:
> Update the comment here (and in 88) that this also sets the accessible-name,
and
> SetAccessibleName should be used if it needs to be different.

Done.

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:97: void SetAccessibleName(const string16& name);
On 2012/04/19 11:33:58, sadrul wrote:
> Remove this.

Done.

https://chromiumcodereview.appspot.com/10078009/diff/1/ash/system/tray/tray_v...
ash/system/tray/tray_views.h:116: string16 accessible_name_;
On 2012/04/19 11:33:58, sadrul wrote:
> And this

Done.

[sadrul, 2012-04-20 18:04:46]

LGTM

[commit-bot: I haz the power, 2012-04-23 01:42:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10078009/6001

[commit-bot: I haz the power, 2012-04-23 04:11:08]

Change committed as 133403