Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 10075001: add more color formats NV21 and YV12 in video capture (mainly from Android). (Closed)

Created:
8 years, 8 months ago by wjia(left Chromium)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

add more color formats NV21 and YV12 in video capture (mainly from Android). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132808

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M media/base/yuv_convert.h View 1 chunk +7 lines, -0 lines 2 comments Download
M media/base/yuv_convert.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M media/video/capture/video_capture_device.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wjia(left Chromium)
8 years, 8 months ago (2012-04-12 21:31:08 UTC) #1
scherkus (not reviewing)
LGTM w/ q http://codereview.chromium.org/10075001/diff/1/media/base/yuv_convert.h File media/base/yuv_convert.h (right): http://codereview.chromium.org/10075001/diff/1/media/base/yuv_convert.h#newcode116 media/base/yuv_convert.h:116: void ConvertNV21ToYUV(const uint8* src, do you ...
8 years, 8 months ago (2012-04-13 03:01:57 UTC) #2
scherkus (not reviewing)
is there a BUG= or test for this?
8 years, 8 months ago (2012-04-13 03:02:15 UTC) #3
wjia(left Chromium)
There is no BUG # for this. http://codereview.chromium.org/10075001/diff/1/media/base/yuv_convert.h File media/base/yuv_convert.h (right): http://codereview.chromium.org/10075001/diff/1/media/base/yuv_convert.h#newcode116 media/base/yuv_convert.h:116: void ConvertNV21ToYUV(const ...
8 years, 8 months ago (2012-04-17 23:49:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjia@chromium.org/10075001/1
8 years, 8 months ago (2012-04-17 23:49:46 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-18 00:23:36 UTC) #6
Try job failure for 10075001-1 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698