Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 100743006: Fix DCHECK() when updating instruments with no phone number. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 127706e00e66ec3e4b4e5dff3601c6df10de40d0..cd6d63ee083496e1f556b7d80b987803de06154c 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -3169,6 +3169,13 @@ void AutofillDialogControllerImpl::SubmitWithWallet() {
if (inputted_instrument && IsEditingExistingData(SECTION_CC_BILLING)) {
inputted_instrument->set_object_id(active_instrument->object_id());
Evan Stade 2013/12/07 02:36:12 then you can remove this?
Dan Beam 2013/12/10 22:04:31 Done.
DCHECK(!inputted_instrument->object_id().empty());
+
+ int server_month = active_instrument->expiration_month();
+ int server_year = active_instrument->expiration_month();
Evan Stade 2013/12/07 02:36:12 I'd rather you pass active_instrument_ to SaveToWa
Dan Beam 2013/12/10 22:04:31 Done.
+ if (server_month != inputted_instrument->expiration_month() ||
+ server_year != inputted_instrument->expiration_year()) {
+ inputted_instrument->set_expiration_differs_from_server(true);
+ }
}
scoped_ptr<wallet::Address> inputted_address;

Powered by Google App Engine
This is Rietveld 408576698