Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100743006: Fix DCHECK() when updating instruments with no phone number. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Fix DCHECK() when updating instruments with no phone number. Also refactors SaveToWallet() to take a |reference_{instrument,address}| instead of setting an object_id in the controller as well as refactors the way that WalletClient queues pending requests to be less error prone and maybe copy less memory? (definitely simpler) R=estade@chromium.org BUG=326671 TEST=unit_tests NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240873

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : . #

Patch Set 4 : fix #

Patch Set 5 : . #

Patch Set 6 : remove set_object_id #

Patch Set 7 : nits #

Patch Set 8 : dcheck #

Total comments: 8

Patch Set 9 : estade@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -211 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 4 5 6 7 8 7 chunks +26 lines, -8 lines 0 comments Download
M components/autofill/content/browser/wallet/instrument.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/mock_wallet_client.h View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -5 lines 0 comments Download
M components/autofill/content/browser/wallet/mock_wallet_client.cc View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -3 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.h View 1 2 3 4 5 6 7 8 2 chunks +11 lines, -4 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 1 2 3 4 5 6 7 8 10 chunks +48 lines, -68 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 2 3 4 5 6 7 8 25 chunks +89 lines, -41 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_test_util.cc View 1 2 3 4 5 6 6 chunks +64 lines, -71 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Dan Beam
7 years ago (2013-12-07 02:07:28 UTC) #1
Evan Stade
https://chromiumcodereview.appspot.com/100743006/diff/20001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/100743006/diff/20001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode3170 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:3170: inputted_instrument->set_object_id(active_instrument->object_id()); then you can remove this? https://chromiumcodereview.appspot.com/100743006/diff/20001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode3174 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:3174: int ...
7 years ago (2013-12-07 02:36:12 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/100743006/diff/20001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://chromiumcodereview.appspot.com/100743006/diff/20001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode3170 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:3170: inputted_instrument->set_object_id(active_instrument->object_id()); On 2013/12/07 02:36:12, Evan Stade wrote: > then ...
7 years ago (2013-12-10 22:04:30 UTC) #3
Dan Beam
wait to review this
7 years ago (2013-12-10 23:04:04 UTC) #4
Dan Beam
ok, ready to review
7 years ago (2013-12-11 18:00:45 UTC) #5
Evan Stade
https://codereview.chromium.org/100743006/diff/130001/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/100743006/diff/130001/components/autofill/content/browser/wallet/wallet_client.cc#newcode386 components/autofill/content/browser/wallet/wallet_client.cc:386: base::Unretained(server_instrument), this is no bueno... you need to make ...
7 years ago (2013-12-12 02:33:57 UTC) #6
Dan Beam
https://codereview.chromium.org/100743006/diff/130001/components/autofill/content/browser/wallet/wallet_client.cc File components/autofill/content/browser/wallet/wallet_client.cc (right): https://codereview.chromium.org/100743006/diff/130001/components/autofill/content/browser/wallet/wallet_client.cc#newcode386 components/autofill/content/browser/wallet/wallet_client.cc:386: base::Unretained(server_instrument), On 2013/12/12 02:33:57, Evan Stade wrote: > this ...
7 years ago (2013-12-13 04:06:23 UTC) #7
Dan Beam
ping if you get a chance
7 years ago (2013-12-13 18:05:05 UTC) #8
Evan Stade
yay, lgtm
7 years ago (2013-12-13 23:42:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-13 23:53:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=203813
7 years ago (2013-12-14 01:23:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-14 01:26:48 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=203884
7 years ago (2013-12-14 02:41:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-14 02:46:17 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=203991
7 years ago (2013-12-14 05:03:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-14 05:08:49 UTC) #16
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204044
7 years ago (2013-12-14 06:22:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-14 07:57:19 UTC) #18
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204115
7 years ago (2013-12-14 09:02:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/100743006/150001
7 years ago (2013-12-14 10:06:24 UTC) #20
commit-bot: I haz the power
7 years ago (2013-12-16 13:08:02 UTC) #21
Message was sent while issue was closed. 
Change committed as 240873

Powered by Google App Engine
This is Rietveld 408576698