Add Delete Support to New Autofill UI

chrome/browser/autofill/autofill_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/string16.h"
@@ skipping 67 matching lines @@
 
   AutofillProfile* GetProfileWithGUID(const char* guid) {
     for (std::vector<AutofillProfile *>::iterator it = web_profiles_.begin();
          it != web_profiles_.end(); ++it) {
       if (!(*it)->guid().compare(guid))
         return *it;
     }
     return NULL;
   }
 
+  CreditCard* GetCreditCardWithGUID(const char* guid) {
+    for (std::vector<CreditCard *>::iterator it = credit_cards_.begin();
+         it != credit_cards_.end(); ++it){
+      if (!(*it)->guid().compare(guid))
+        return *it;
+    }
+    return NULL;
+  }
+
   void AddProfile(AutofillProfile* profile) {
     web_profiles_->push_back(profile);
   }
 
   void AddCreditCard(CreditCard* credit_card) {
     credit_cards_->push_back(credit_card);
   }
 
+  virtual void RemoveProfile(const std::string& guid) OVERRIDE {
+    AutofillProfile* profile = GetProfileWithGUID(guid.c_str());
+
+    for (std::vector<AutofillProfile *>::iterator it = web_profiles_.begin();
+         it != web_profiles_.end(); ++it){
+      if (*it == profile) {
+        web_profiles_.erase(it);
+        return;
+      }
+    }

[Ilya Sherman, 2012/04/18 18:12:51]

nit: Perhaps replace this loop with a call to std::remove() (defined in the
<algorithm> header)?

[csharp, 2012/04/19 15:33:24]

Done.

+  }
+
+  virtual void RemoveCreditCard(const std::string& guid) OVERRIDE {
+    CreditCard* credit_card = GetCreditCardWithGUID(guid.c_str());
+
+    for (std::vector<CreditCard *>::iterator it = credit_cards_.begin();
+         it != credit_cards_.end(); ++it){
+      if (*it == credit_card) {
+        credit_cards_.erase(it);
+        return;
+      }
+    }

[Ilya Sherman, 2012/04/18 18:12:51]

nit: Perhaps replace this loop with a call to std::remove() (defined in the
<algorithm> header)?

[csharp, 2012/04/19 15:33:24]

Done.

+  }
+
   void ClearAutofillProfiles() {
     web_profiles_.reset();
   }
 
   void ClearCreditCards() {
     credit_cards_.reset();
   }
 
   void CreateTestCreditCardsYearAndMonth(const char* year, const char* month) {
     ClearCreditCards();
@@ skipping 395 matching lines @@
   }
 
   const std::string GetSubmittedFormSignature() {
     return submitted_form_signature_;
   }
 
   AutofillProfile* GetProfileWithGUID(const char* guid) {
     return personal_data_->GetProfileWithGUID(guid);
   }
 
+  CreditCard* GetCreditCardWithGUID(const char* guid) {
+    return personal_data_->GetCreditCardWithGUID(guid);
+  }
+
   void AddProfile(AutofillProfile* profile) {
     personal_data_->AddProfile(profile);
   }
 
   void AddCreditCard(CreditCard* credit_card) {
     personal_data_->AddCreditCard(credit_card);
   }
 
   int GetPackedCreditCardID(int credit_card_id) {
     std::string credit_card_guid =
@@ skipping 2402 matching lines @@
   autofill_manager_->ClearSentStates();
 
   // When a new render_view is created, we send the state even if it's the
   // same.
   UpdatePasswordSyncState(true);
   EXPECT_EQ(1u, autofill_manager_->GetSentStates().size());
   EXPECT_FALSE(autofill_manager_->GetSentStates()[0]);
   autofill_manager_->ClearSentStates();
 }
 
+TEST_F(AutofillManagerTest, RemoveProfile) {
+  // Add and remove an Autofill profile.
+  AutofillProfile* profile = new AutofillProfile;
+  std::string guid ="00000000-0000-0000-0000-000000000102";

[Ilya Sherman, 2012/04/18 18:12:51]

nit: Missing space between the = sign and the quote.

[csharp, 2012/04/19 15:33:24]

Done.

+  profile->set_guid(guid.c_str());
+  autofill_manager_->AddProfile(profile);
+
+  GUIDPair guid_pair(guid, 1);
+  GUIDPair empty(std::string(), 0);
+  int id = PackGUIDs(empty, guid_pair);
+
+  autofill_manager_->RemoveAutofillProfileOrCreditCard(id);
+
+  EXPECT_EQ(NULL, autofill_manager_->GetProfileWithGUID(guid.c_str()));

[Ilya Sherman, 2012/04/18 18:12:51]

nit: I don't think this compiles on all platforms.  You either need to write
this as EXPECT_EQ(static_cast<AutofillProfile*>(NULL), ...), or as
EXPECT_FALSE(...).

[csharp, 2012/04/19 15:33:24]

Done.

+}
+
+TEST_F(AutofillManagerTest, RemoveCreditCard){
+  // Add and remove and Autofill credit card.

[Ilya Sherman, 2012/04/18 18:12:51]

nit: "remove and" -> "remove an"

[csharp, 2012/04/19 15:33:24]

Done.

+  CreditCard* credit_card = new CreditCard;
+  std::string guid = "00000000-0000-0000-0000-000000100007";
+  credit_card->set_guid(guid.c_str());
+  autofill_manager_->AddCreditCard(credit_card);
+
+  GUIDPair guid_pair(guid, 1);
+  GUIDPair empty(std::string(), 0);
+  int id = PackGUIDs(guid_pair, empty);
+
+  autofill_manager_->RemoveAutofillProfileOrCreditCard(id);
+
+  EXPECT_EQ(NULL, autofill_manager_->GetCreditCardWithGUID(guid.c_str()));
+}
+
 namespace {
 
 class MockAutofillExternalDelegate : public TestAutofillExternalDelegate {
  public:
   explicit MockAutofillExternalDelegate(TabContentsWrapper* wrapper,
                                         AutofillManager* autofill_manager)
       : TestAutofillExternalDelegate(wrapper, autofill_manager) {}
   virtual ~MockAutofillExternalDelegate() {}
 
   MOCK_METHOD5(OnQuery, void(int query_id,
@@ skipping 47 matching lines @@
 
   AutofillManager* autofill_manager = contents_wrapper()->autofill_manager();
   EXPECT_TRUE(autofill_manager->external_delegate());
 
   AutocompleteHistoryManager* autocomplete_history_manager =
       contents_wrapper()->autocomplete_history_manager();
   EXPECT_TRUE(autocomplete_history_manager->external_delegate());
 }
 
 #endif  // OS_ANDROID