Add Delete Support to New Autofill UI

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 44 matching lines @@
 #include "content/public/browser/web_contents.h"
 #include "googleurl/src/gurl.h"
 #include "grit/generated_resources.h"
 #include "ipc/ipc_message_macros.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/rect.h"
 #include "webkit/forms/form_data.h"
 #include "webkit/forms/form_data_predictions.h"
 #include "webkit/forms/form_field.h"
 #include "webkit/forms/password_form_dom_manager.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h"

[Ilya Sherman, 2012/04/19 21:01:57]

nit: alpha-sort (should come before ui/)

[csharp, 2012/04/20 15:03:18]

Done.

 
 using base::TimeTicks;
 using content::BrowserThread;
 using content::RenderViewHost;
 using switches::kEnableAutofillFeedback;
 using webkit::forms::FormData;
 using webkit::forms::FormDataPredictions;
 using webkit::forms::FormField;
 
 namespace {
@@ skipping 606 matching lines @@
 void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   Browser* browser = BrowserList::GetLastActiveWithProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
   browser->window()->ShowPasswordGenerationBubble(bounds);
 #endif  // #if defined(OS_ANDROID)
 }
 
+void AutofillManager::RemoveAutofillProfileOrCreditCard(int unique_id) {
+  const std::vector<AutofillProfile*>& profiles = personal_data_->profiles();
+  const std::vector<CreditCard*>& credit_cards = personal_data_->credit_cards();
+  const AutofillProfile* profile = NULL;
+  const CreditCard* credit_card = NULL;
+  size_t variant = 0;
+  if (!GetProfileOrCreditCard(unique_id, profiles, credit_cards, &profile,
+                              &credit_card, &variant)) {
+    NOTREACHED();
+    return;
+  }
+
+  // TODO(csharp): If we are dealing with a variant only the variant should
+  // be deleted, not the whole profile.
+  // http://crbug.com/124211

[Ilya Sherman, 2012/04/19 21:01:57]

Hmm, this has the potential for accidental data loss.  I'd prefer that we return
early if the variant is non-zero rather than deleting the whole profile, in the
intermediate phase while we don't support deleting specific variants.

[csharp, 2012/04/20 15:03:18]

Done.

+
+  if (profile)
+    personal_data_->RemoveProfile(profile->guid());
+  else
+    personal_data_->RemoveCreditCard(credit_card->guid());
+}
+
 void AutofillManager::OnAddPasswordFormMapping(
       const webkit::forms::FormField& form,
       const webkit::forms::PasswordFormFillData& fill_data) {
   if (external_delegate_)
     external_delegate_->AddPasswordFormMapping(form, fill_data);
 }
 
 void AutofillManager::OnShowPasswordSuggestions(
     const webkit::forms::FormField& field,
     const gfx::Rect& bounds,
@@ skipping 617 matching lines @@
   *profile_guid = IDToGUID(profile_id);
 }
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }