Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10073010: Small improvements to push-to-trunk.sh and merge-to-branch.sh. (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow
Modified:
8 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Small improvements to push-to-trunk.sh and merge-to-branch.sh. 1.) When a back-merged patch applied at an offset, ignore the "Hunk #1 succeeded at ..." lines instead of printing a scary warning. 2.) When push-to-trunk was not called with "-c /path/to/chrome/src", explicitly ask for the path to help discoverability of the feature. 3.) Correctly convert "BUG=chromium:123 " to "(Chromium issue 123)" in the pre-made ChangeLog entry. Committed: https://code.google.com/p/v8/source/detail?r=11321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/common-includes.sh View 1 chunk +2 lines, -1 line 0 comments Download
M tools/push-to-trunk.sh View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
Once more, these changes are untested :-) But they're neither scary nor dangerous. Please take ...
8 years, 8 months ago (2012-04-13 15:34:19 UTC) #1
danno
8 years, 8 months ago (2012-04-13 15:56:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698