Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: lib/uri/uri.dart

Issue 10073001: Fix HTTP links in URI docs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dartdoc/markdown.dart ('k') | tests/utils/src/MarkdownTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/uri/uri.dart
diff --git a/lib/uri/uri.dart b/lib/uri/uri.dart
index 38001228e1b80305c242beae40520bfcd0691023..a1856f7cfbf7f5c01e54d11ff810789ab05b0588 100644
--- a/lib/uri/uri.dart
+++ b/lib/uri/uri.dart
@@ -5,8 +5,9 @@
#library('uri');
/**
- * A parsed URI, inspired by:
- * http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html
+ * A parsed URI, inspired by Closure's [URI][] class. Implements [RFC-3986][].
+ * [uri]: http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html
ahe 2012/04/12 18:24:22 I don't think this follows the conventions we foll
Bob Nystrom 2012/04/16 22:04:23 I didn't even remember that the old guide specifie
+ * [RFC-3986]: http://tools.ietf.org/html/rfc3986#section-4.3)
*/
class Uri {
final String scheme;
@@ -72,9 +73,7 @@ class Uri {
static final _COMPONENT_FRAGMENT = 7;
/**
- * Determines whether a URI is absolute.
- *
- * See: http://tools.ietf.org/html/rfc3986#section-4.3
+ * Returns `true` if the URI is absolute.
ahe 2012/04/12 18:24:22 [true] instead of `true`.
Bob Nystrom 2012/04/16 22:04:23 [true] is for links to identifiers, but "true" is
*/
bool isAbsolute() {
if ("" == scheme) return false;
« no previous file with comments | « lib/dartdoc/markdown.dart ('k') | tests/utils/src/MarkdownTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698