Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 10072004: Merge 113132 - [Chromium] Out-of-process font loading garbles text (Closed)

Created:
8 years, 8 months ago by Dmitry Titov
Modified:
8 years, 8 months ago
Reviewers:
bashi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 113132 - [Chromium] Out-of-process font loading garbles text https://bugs.webkit.org/show_bug.cgi?id=83002 Reviewed by Kent Tamura. Initialize m_CTFont by using m_cgFont in FontPlatformData when we use out-of-process font loading. No new tests. This problem only occurs when the user uses a third party font management software like Font Explorer so it is difficult to add tests. * platform/graphics/chromium/CrossProcessFontLoading.mm: (WebCore): (WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used. * platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process. * platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object. TBR=bashi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M Source/WebCore/platform/graphics/chromium/CrossProcessFontLoading.mm View 3 chunks +4 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/mac/FontCacheMac.mm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dmitry Titov
8 years, 8 months ago (2012-04-13 02:45:47 UTC) #1
bashi
8 years, 8 months ago (2012-04-13 02:47:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698