content/browser/speech/speech_recognition_manager_impl.h - Issue 10071040: Fixed a memory leak in SpeechRecognitionManagerImpl causing ChromeSpeechInputManagerDelegate to be …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.h

Issue 10071040: Fixed a memory leak in SpeechRecognitionManagerImpl causing ChromeSpeechInputManagerDelegate to be … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nits according to jam@ review. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/speech/speech_recognition_manager_impl.h

diff --git a/content/browser/speech/speech_recognition_manager_impl.h b/content/browser/speech/speech_recognition_manager_impl.h

index f063a15afe644b137133d68f00d58f570b9fc448..bb38cecf677ffa6f00e2cbbad22a5800c8b90008 100644

--- a/content/browser/speech/speech_recognition_manager_impl.h

+++ b/content/browser/speech/speech_recognition_manager_impl.h

@@ -11,6 +11,7 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

#include "base/memory/ref_counted.h"

+#include "base/memory/scoped_ptr.h"

#include "base/memory/singleton.h"

#include "content/public/browser/speech_recognition_event_listener.h"

#include "content/public/browser/speech_recognition_manager.h"

@@ -119,7 +120,7 @@ class CONTENT_EXPORT SpeechRecognitionManagerImpl

std::string request_info_;

bool can_report_metrics_;

int recording_caller_id_;

- content::SpeechRecognitionManagerDelegate* delegate_;

+ scoped_ptr<content::SpeechRecognitionManagerDelegate> delegate_;

};

} // namespace speech

« no previous file with comments | « no previous file | content/browser/speech/speech_recognition_manager_impl.cc » ('j') | no next file with comments »