Fixed issue with shrink output when using system print dialog.

Fixed issue with shrink output when using system print dialog.

BUG=122363
TEST=Print webpage using system print dialog on Windows. Output should look normal.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132319

[Albert Bodenhamer, 2012-04-12 21:03:13]

lgtm

[commit-bot: I haz the power, 2012-04-12 21:07:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10071024/1

[gene, 2012-04-13 21:28:44]

Please take a look again. Now both print preview and system print works.
It is somewhat an ugly code to fix this issue. But the proper solution will
involve significantly more time at this point. I've added comments on how this
should be fixed later.

[gene, 2012-04-13 21:37:00]

Created a bug for future code improvement and referenced it from the comment.

[Albert Bodenhamer, 2012-04-13 21:40:45]

lgtm
with nits

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
chrome/renderer/print_web_view_helper_win.cc:119: // It creates a temp metafile
based on screen DC. The standart scale factor
standart -> standard

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
chrome/renderer/print_web_view_helper_win.cc:124: // In such case we need to
calculate the same scale ration PDF plugin will
ration -> ratio

[Lei Zhang, 2012-04-13 21:49:17]

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.cc:755: printing_from_preview_ = true;
Do you want to move this up to line 746 and get rid of the last argument to
UpdatePrintSettings() then? Maybe make |printing_from_preview_| AutoReset?

In UpdatePrintSettings(), the parameter for this is "print_for_preview". Do you
like that name better?

[Lei Zhang, 2012-04-13 21:49:40]

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.h (right):

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.h:372: // True, when priniting from print
preview.
nit: Typo.

[gene, 2012-04-13 22:11:02]

Please take a look.

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.cc:755: printing_from_preview_ = true;
I am using AutoReset now and move up as suggested.
"print_for_preview" - looks good for me, done.
I would like to keep changes to the minimum, so it is easier to pick up this CL
for m19 merge. Inside UpdatePrintSettings print_for_preview is used quite
intensively, so, I would like to do this in a separate CL.

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.h (right):

https://chromiumcodereview.appspot.com/10071024/diff/8001/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.h:372: // True, when priniting from print
preview.
On 2012/04/13 21:49:40, Lei Zhang wrote:
> nit: Typo.

Done.

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
File chrome/renderer/print_web_view_helper_win.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
chrome/renderer/print_web_view_helper_win.cc:119: // It creates a temp metafile
based on screen DC. The standart scale factor
On 2012/04/13 21:40:45, Albert Bodenhamer wrote:
> standart -> standard

Done.

https://chromiumcodereview.appspot.com/10071024/diff/13002/chrome/renderer/pr...
chrome/renderer/print_web_view_helper_win.cc:124: // In such case we need to
calculate the same scale ration PDF plugin will
On 2012/04/13 21:40:45, Albert Bodenhamer wrote:
> ration -> ratio

Done.

[Lei Zhang, 2012-04-13 22:15:08]

lgtm

https://chromiumcodereview.appspot.com/10071024/diff/9005/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/9005/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.cc:748: // Set print_for_preview_ flag and
autoreset it to back to original
nit: |print_for_preview_| and same below.

[gene, 2012-04-13 22:18:17]

https://chromiumcodereview.appspot.com/10071024/diff/9005/chrome/renderer/pri...
File chrome/renderer/print_web_view_helper.cc (right):

https://chromiumcodereview.appspot.com/10071024/diff/9005/chrome/renderer/pri...
chrome/renderer/print_web_view_helper.cc:748: // Set print_for_preview_ flag and
autoreset it to back to original
On 2012/04/13 22:15:08, Lei Zhang wrote:
> nit: |print_for_preview_| and same below.

Done.

[commit-bot: I haz the power, 2012-04-13 22:55:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10071024/10006

[commit-bot: I haz the power, 2012-04-13 23:35:15]

Try job failure for 10071024-10006 (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-13 23:42:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10071024/12006

[commit-bot: I haz the power, 2012-04-14 01:35:49]

Try job failure for 10071024-12006 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-14 02:06:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gene@chromium.org/10071024/12006

[commit-bot: I haz the power, 2012-04-14 03:20:34]

Change committed as 132319