Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 10071009: Prepare DefinePropertyAccessor for callback transitions. (Closed)

Created:
8 years, 8 months ago by Sven Panne
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Prepare DefinePropertyAccessor for callback transitions. Although things are currently OK here, in the future it won't be enough to check for the existence of a CALLBACKS result, we must additionally check that it actually contains an accessor. In a nutshell: 'sed s/IsFound/IsProperty/' once again... Additionally, the control flow in DefinePropertyAccessor has been simplified by using a helper function. Committed: https://code.google.com/p/v8/source/detail?r=11305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +14 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 8 months ago (2012-04-12 12:59:52 UTC) #1
Michael Starzinger
8 years, 8 months ago (2012-04-13 09:26:11 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698