Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 10071004: MIPS: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed (Closed)

Created:
8 years, 8 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed Port r11278 (e5dc7ebd). Original commit message: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed: - if value is a result of integer32 to double conversion (can't be NaN); - if value was loaded from fast double backing store (already canonicalized). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11366

Patch Set 1 #

Patch Set 2 : rebased on r11356 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kalmard
8 years, 8 months ago (2012-04-12 11:26:24 UTC) #1
kalmard
rebased on r11356
8 years, 8 months ago (2012-04-17 14:45:03 UTC) #2
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-18 10:42:03 UTC) #3
LGTM, landing

Powered by Google App Engine
This is Rietveld 408576698