Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Issue 10071003: Cleanup test-alloc unit test case. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger
Modified:
8 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Cleanup test-alloc unit test case. This makes the test-alloc test case more robust against changes to the initial heap size. It correctly simulates a full space now instead of trying to fill the space up by allocating filler objects. R=svenpanne@chromium.org TEST=cctest/test-alloc Committed: https://code.google.com/p/v8/source/detail?r=11284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M src/spaces.h View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-alloc.cc View 3 chunks +12 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 8 months ago (2012-04-12 09:42:40 UTC) #1
Sven Panne
8 years, 8 months ago (2012-04-12 10:03:28 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698