Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1668)

Unified Diff: content/shell/shell_login_dialog.h

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to Trunk Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/shell_browser_context.cc ('k') | content/shell/shell_login_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_login_dialog.h
diff --git a/content/shell/shell_login_dialog.h b/content/shell/shell_login_dialog.h
index b944c195fefdfb24a79b36319266b85c17dcb7e6..ff259f9e169c92dd37e8cfaa3ee5549e346188f8 100644
--- a/content/shell/shell_login_dialog.h
+++ b/content/shell/shell_login_dialog.h
@@ -31,8 +31,6 @@ class ShellLoginDialog : public ResourceDispatcherHostLoginDelegate {
public:
// Threading: IO thread.
ShellLoginDialog(net::AuthChallengeInfo* auth_info, net::URLRequest* request);
- // Threading: any
- virtual ~ShellLoginDialog();
// ResourceDispatcherHostLoginDelegate implementation:
// Threading: IO thread.
@@ -45,6 +43,10 @@ class ShellLoginDialog : public ResourceDispatcherHostLoginDelegate {
void UserAcceptedAuth(const string16& username, const string16& password);
void UserCancelledAuth();
+ protected:
+ // Threading: any
+ virtual ~ShellLoginDialog();
+
private:
// All the methods that begin with Platform need to be implemented by the
// platform specific LoginDialog implementation.
« no previous file with comments | « content/shell/shell_browser_context.cc ('k') | content/shell/shell_login_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698