Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: content/shell/shell_browser_context.cc

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to Trunk Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/speech_recognizer.h ('k') | content/shell/shell_login_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_browser_context.cc
diff --git a/content/shell/shell_browser_context.cc b/content/shell/shell_browser_context.cc
index 8c824532a0f7086468b557e5d1a501166cb6c982..678edfce886cc2b973df8a040c0c7456c6ba69c6 100644
--- a/content/shell/shell_browser_context.cc
+++ b/content/shell/shell_browser_context.cc
@@ -39,8 +39,7 @@ const char kXdgConfigHomeEnvVar[] = "XDG_CONFIG_HOME";
class ShellGeolocationPermissionContext : public GeolocationPermissionContext {
public:
- ShellGeolocationPermissionContext() {
- }
+ ShellGeolocationPermissionContext() {}
// GeolocationPermissionContext implementation).
virtual void RequestGeolocationPermission(
@@ -60,22 +59,26 @@ class ShellGeolocationPermissionContext : public GeolocationPermissionContext {
NOTIMPLEMENTED();
}
+ protected:
+ virtual ~ShellGeolocationPermissionContext() {};
+
private:
DISALLOW_COPY_AND_ASSIGN(ShellGeolocationPermissionContext);
};
class ShellSpeechRecognitionPreferences : public SpeechRecognitionPreferences {
public:
- ShellSpeechRecognitionPreferences() {
- }
+ ShellSpeechRecognitionPreferences() {}
// Overridden from SpeechRecognitionPreferences:
virtual bool FilterProfanities() const OVERRIDE {
return false;
}
- virtual void SetFilterProfanities(bool filter_profanities) OVERRIDE {
- }
+ virtual void SetFilterProfanities(bool filter_profanities) OVERRIDE {}
+
+ protected:
+ virtual ~ShellSpeechRecognitionPreferences() {}
private:
DISALLOW_COPY_AND_ASSIGN(ShellSpeechRecognitionPreferences);
« no previous file with comments | « content/public/browser/speech_recognizer.h ('k') | content/shell/shell_login_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698