Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: content/public/browser/download_manager.h

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to Trunk Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/browser_message_filter.cc ('k') | content/public/browser/indexed_db_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index b0039bde6dc72f162c9135bebc14ee0eec8c6afd..b405a5512aa7ce6b769b112287ff967ab9e4957d 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -60,8 +60,6 @@ class DownloadUrlParameters;
class CONTENT_EXPORT DownloadManager
: public base::RefCountedThreadSafe<DownloadManager> {
public:
- virtual ~DownloadManager() {}
-
static DownloadManager* Create(
DownloadManagerDelegate* delegate,
net::NetLog* net_log);
@@ -247,11 +245,11 @@ class CONTENT_EXPORT DownloadManager
virtual void SetDownloadManagerDelegate(
DownloadManagerDelegate* delegate) = 0;
+ protected:
+ virtual ~DownloadManager() {}
+
private:
- friend class base::RefCountedThreadSafe<
- DownloadManager, BrowserThread::DeleteOnUIThread>;
- friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
- friend class base::DeleteHelper<DownloadManager>;
+ friend class base::RefCountedThreadSafe<DownloadManager>;
};
} // namespace content
« no previous file with comments | « content/public/browser/browser_message_filter.cc ('k') | content/public/browser/indexed_db_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698