Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: runtime/bin/process_impl.dart

Issue 10069053: Fix Process test, fix Process factory, diable tests on dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/src/io/ProcessRunOutputTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process_impl.dart
diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart
index 86e577979d97105bde3f004a99462837e2a9f69a..3811091c2264c20acb4c9194c238c102388b345a 100644
--- a/runtime/bin/process_impl.dart
+++ b/runtime/bin/process_impl.dart
@@ -10,22 +10,20 @@ class _ProcessStartStatus {
// Abstract factory class capable of producing interactive and
// non-interactive processes.
-class _Process implements Process {
+class _Process {
- _Process();
-
- factory _Process.start(String path,
- List<String> arguments,
- [ProcessOptions options]) {
+ factory Process.start(String path,
+ List<String> arguments,
+ [ProcessOptions options]) {
return new _InteractiveProcess.start(path, arguments, options);
}
- factory _Process.run(String path,
- List<String> arguments,
- ProcessOptions options,
- void callback(int exitCode,
- String stdout,
- String stderr)) {
+ factory Process.run(String path,
+ List<String> arguments,
+ ProcessOptions options,
+ void callback(int exitCode,
+ String stdout,
+ String stderr)) {
return new _NonInteractiveProcess.start(path,
arguments,
options,
@@ -36,7 +34,7 @@ class _Process implements Process {
// _InteractiveProcess is the actual implementation of all processes
// started from Dart code.
-class _InteractiveProcess extends _Process {
+class _InteractiveProcess implements Process {
_InteractiveProcess.start(String path,
List<String> arguments,
@@ -295,7 +293,7 @@ class _InteractiveProcess extends _Process {
// that restricts the interface to disallow access to the streams and
// buffers output so it can be delivered to the callback when the
// process exits.
-class _NonInteractiveProcess extends _Process {
+class _NonInteractiveProcess implements Process {
_NonInteractiveProcess.start(String path,
List<String> arguments,
« no previous file with comments | « no previous file | tests/standalone/src/io/ProcessRunOutputTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698