Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 10069047: Delete run_sigpipe_test. (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, noelallen1
Base URL:
http://src.chromium.org/native_client/trunk/src/native_client/
Visibility:
Public.

Description

Delete run_sigpipe_test. Building all targets shouldn't execute tests, it should just build. landed in r8259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M src/shared/imc/imc.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
8 years, 8 months ago (2012-04-13 04:48:36 UTC) #1
Mark Seaborn
I agree, so LGTM. Having said that, there are one or two other Gyp targets ...
8 years, 8 months ago (2012-04-13 16:38:09 UTC) #2
Nico
8 years, 8 months ago (2012-04-13 18:16:58 UTC) #3
Thanks, landed in r8259. I'd delete other tests that run at build time too, but
I haven't found them yet.

Powered by Google App Engine
This is Rietveld 408576698