Issue 10069045: Flag files needed for the symbol server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10069045: Flag files needed for the symbol server. (Closed)

Created:
8 years, 8 months ago by Michael Moss

Modified:
8 years, 8 months ago

Reviewers:
kerz_chromium, Sigurður Ásgeirsson

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Flag files needed for the symbol server. This is part of removing more hard-coded file lists from the buildbot scripts, specifically symsrc_binaries from site_config/config.py. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132189

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	chrome/tools/build/win/FILES.cfg	View		6 chunks	+18 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

https://chromiumcodereview.appspot.com/10069045/diff/1/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://chromiumcodereview.appspot.com/10069045/diff/1/chrome/tools/build/win/FILES.cfg#newcode466 chrome/tools/build/win/FILES.cfg:466: 'filegroup': ['symsrc'], Does this mean that this file will ...

8 years, 8 months ago (2012-04-13 14:56:15 UTC) #3

Michael Moss

8 years, 8 months ago (2012-04-13 15:09:01 UTC) #4

https://chromiumcodereview.appspot.com/10069045/diff/1/chrome/tools/build/win...
File chrome/tools/build/win/FILES.cfg (right):

https://chromiumcodereview.appspot.com/10069045/diff/1/chrome/tools/build/win...
chrome/tools/build/win/FILES.cfg:466: 'filegroup': ['symsrc'],
No, it's just a means of extracting subsets of files for different purposes.
It's still archived based on the 'archive' field, and could belong to additional
groups if we ever wanted that.

Expand Messages | Collapse Messages