Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: chrome/browser/ui/views/status_bubble_views.h

Issue 10069043: Makes the status bubble less janky on chromeos. Any time the bounds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add null check Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_
6 #define CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 103
104 // Used to elide the original URL again when we expand it. 104 // Used to elide the original URL again when we expand it.
105 std::string languages_; 105 std::string languages_;
106 106
107 // Position relative to the base_view_. 107 // Position relative to the base_view_.
108 gfx::Point original_position_; 108 gfx::Point original_position_;
109 // original_position_ adjusted according to the current RTL. 109 // original_position_ adjusted according to the current RTL.
110 gfx::Point position_; 110 gfx::Point position_;
111 gfx::Size size_; 111 gfx::Size size_;
112 112
113 // Last location passed to MouseMoved().
114 gfx::Point last_mouse_moved_location_;
115
116 // Whether the view contains the mouse.
117 bool contains_mouse_;
118
113 // How vertically offset the bubble is from its root position_. 119 // How vertically offset the bubble is from its root position_.
114 int offset_; 120 int offset_;
115 121
116 // We use a HWND for the popup so that it may float above any HWNDs in our 122 // We use a HWND for the popup so that it may float above any HWNDs in our
117 // UI (the location bar, for example). 123 // UI (the location bar, for example).
118 scoped_ptr<views::Widget> popup_; 124 scoped_ptr<views::Widget> popup_;
119 double opacity_; 125 double opacity_;
120 126
121 views::View* base_view_; 127 views::View* base_view_;
122 StatusView* view_; 128 StatusView* view_;
123 129
124 // Manages the expansion of a status bubble to fit a long URL. 130 // Manages the expansion of a status bubble to fit a long URL.
125 scoped_ptr<StatusViewExpander> expand_view_; 131 scoped_ptr<StatusViewExpander> expand_view_;
126 132
127 // If the download shelf is visible, do not obscure it. 133 // If the download shelf is visible, do not obscure it.
128 bool download_shelf_is_visible_; 134 bool download_shelf_is_visible_;
129 135
130 // If the bubble has already been expanded, and encounters a new URL, 136 // If the bubble has already been expanded, and encounters a new URL,
131 // change size immediately, with no hover. 137 // change size immediately, with no hover.
132 bool is_expanded_; 138 bool is_expanded_;
133 139
134 // Times expansion of status bubble when URL is too long for standard width. 140 // Times expansion of status bubble when URL is too long for standard width.
135 base::WeakPtrFactory<StatusBubbleViews> expand_timer_factory_; 141 base::WeakPtrFactory<StatusBubbleViews> expand_timer_factory_;
136 142
137 DISALLOW_COPY_AND_ASSIGN(StatusBubbleViews); 143 DISALLOW_COPY_AND_ASSIGN(StatusBubbleViews);
138 }; 144 };
139 145
140 #endif // CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_ 146 #endif // CHROME_BROWSER_UI_VIEWS_STATUS_BUBBLE_VIEWS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698