Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 10069035: Add a way to implement GetInterface in the broker. (Closed)

Created:
8 years, 8 months ago by brettw
Modified:
8 years, 8 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Add a way to implement GetInterface in the broker. This also adds some cleanup in the Pepper API to provide typedefs for the three PPP_* functions. I removed some ad-hoc typedefes we had floating around and replaced them with these more "official" ones. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132285

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -26 lines) Patch
M content/ppapi_plugin/plugin_process_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/plugin_process_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/ppp.idl View 1 chunk +15 lines, -0 lines 0 comments Download
M ppapi/c/ppp.h View 2 chunks +29 lines, -2 lines 3 comments Download
M ppapi/cpp/module_embedder.h View 2 chunks +15 lines, -0 lines 0 comments Download
M ppapi/cpp/ppp_entrypoints.cc View 3 chunks +10 lines, -1 line 1 comment Download
M ppapi/proxy/dispatcher.h View 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/proxy_channel.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
8 years, 8 months ago (2012-04-12 21:42:34 UTC) #1
viettrungluu
8 years, 8 months ago (2012-04-12 22:14:07 UTC) #2
LGTM w/nits.

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/c/ppp.h
File ppapi/c/ppp.h (right):

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/c/ppp.h#newcode142
ppapi/c/ppp.h:142: PPB_GetInterface get_interface);
Nit: Should you call this |get_browser_interface| to be consistent with the
declaration of |PPP_InitializeModule()|?

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/c/ppp.h#newcode145
ppapi/c/ppp.h:145: * Defines the type of the <code>PPP_ShutdownModule</code>
function.
PPP_GetInterface

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/c/ppp.h#newcode147
ppapi/c/ppp.h:147: typedef const void* (*PP_GetInterface_Func)(const char*
interface_name);
Nit: Keep the same order as the PPP_... declarations (initialize, shutdown, get
iface)?

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/cpp/ppp_entrypoi...
File ppapi/cpp/ppp_entrypoints.cc (right):

https://chromiumcodereview.appspot.com/10069035/diff/1/ppapi/cpp/ppp_entrypoi...
ppapi/cpp/ppp_entrypoints.cc:54: if (!g_module_singleton) {
Nit: Maybe it'd be nicer to write this function as:

if (g_module_singleton)
  return ...;
if (g_broker_get_interface)
  return ...;
return NULL;

Powered by Google App Engine
This is Rietveld 408576698