Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

Issue 10069022: Got rid of peculiar null literal in parsing an incomplete new expression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/DartParser.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
index 5a04f08fa2cab34397a495ae410b2e9219c4f2b7..d56634c58d236e5615906eab2dba7f92bf113151 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java
@@ -1,11 +1,11 @@
/*
* Copyright (c) 2012, the Dart project authors.
- *
+ *
* Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
- *
+ *
* http://www.eclipse.org/legal/epl-v10.html
- *
+ *
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
@@ -34,7 +34,6 @@ import com.google.dart.compiler.ast.DartMethodDefinition;
import com.google.dart.compiler.ast.DartMethodInvocation;
import com.google.dart.compiler.ast.DartNewExpression;
import com.google.dart.compiler.ast.DartNode;
-import com.google.dart.compiler.ast.DartNullLiteral;
import com.google.dart.compiler.ast.DartParameter;
import com.google.dart.compiler.ast.DartPropertyAccess;
import com.google.dart.compiler.ast.DartReturnStatement;
@@ -84,7 +83,6 @@ import com.google.dart.tools.core.internal.completion.ScopedNameFinder.ScopedNam
import com.google.dart.tools.core.internal.completion.ast.BlockCompleter;
import com.google.dart.tools.core.internal.completion.ast.FunctionCompleter;
import com.google.dart.tools.core.internal.completion.ast.MethodInvocationCompleter;
-import com.google.dart.tools.core.internal.completion.ast.NewExpressionCompleter;
import com.google.dart.tools.core.internal.completion.ast.ParameterCompleter;
import com.google.dart.tools.core.internal.completion.ast.PropertyAccessCompleter;
import com.google.dart.tools.core.internal.completion.ast.TypeCompleter;
@@ -776,35 +774,6 @@ public class CompletionEngine {
}
@Override
- public Void visitNullLiteral(DartNullLiteral node) {
- if (node.getParent() instanceof NewExpressionCompleter) {
- // this odd AST is the price of better error recovery
- NewExpressionCompleter newExpr = (NewExpressionCompleter) node.getParent();
- SourceInfo loc = newExpr.getConstructor().getSourceInfo();
- if (loc.getOffset() + loc.getLength() == actualCompletionPosition + 1) {
- DartNode cons = newExpr.getConstructor();
- DartIdentifier typeName;
- if (cons instanceof DartTypeNode) {
- // f() {var x=new List!}
- typeName = (DartIdentifier) ((DartTypeNode) cons).getIdentifier();
- } else if (cons instanceof DartPropertyAccess) {
- if (isCompletionAfterDot) {
- // f() {var x=new List.!}
- return ((DartPropertyAccess) cons).getQualifier().accept(this);
- } else {
- // f() {var x=new html.Element!}
- typeName = ((DartPropertyAccess) cons).getName();
- }
- } else {
- return null; // not reached;
- }
- node.getParent().accept(new IdentifierCompletionProposer(typeName));
- }
- }
- return visitLiteral(node);
- }
-
- @Override
public Void visitParameter(DartParameter node) {
// parameter type prefix: bar(B!) {} or bar(1, B!) {}
if (node instanceof ParameterCompleter) {
« no previous file with comments | « compiler/java/com/google/dart/compiler/parser/DartParser.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698