Log Gaia response codes to ease diagnostics of networking issues.

remoting/host/gaia_oauth_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/gaia_oauth_client.h"
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
@@ skipping 117 matching lines @@
   }
 }
 
 void GaiaOAuthClient::Core::HandleResponse(
     const content::URLFetcher* source,
     bool* should_retry_request) {
   *should_retry_request = false;
   // RC_BAD_REQUEST means the arguments are invalid. No point retrying. We are
   // done here.
   if (source->GetResponseCode() == net::HTTP_BAD_REQUEST) {
+    VLOG(1) << "Gaia response: response code=net::HTTP_BAD_REQUEST.";

[Jamie, 2012/04/12 18:20:20]

I think I would lean towards using LOG(ERROR) in this case. We really don't
expect this to happen under normal circumstances.

     delegate_->OnOAuthError();
     return;
   }
   std::string access_token;
   std::string refresh_token;
   int expires_in_seconds = 0;
   if (source->GetResponseCode() == net::HTTP_OK) {
     std::string data;
     source->GetResponseAsString(&data);
     scoped_ptr<Value> message_value(base::JSONReader::Read(data));
     if (message_value.get() &&
         message_value->IsType(Value::TYPE_DICTIONARY)) {
       scoped_ptr<DictionaryValue> response_dict(
           static_cast<DictionaryValue*>(message_value.release()));
       response_dict->GetString(kAccessTokenValue, &access_token);
       response_dict->GetString(kRefreshTokenValue, &refresh_token);
       response_dict->GetInteger(kExpiresInValue, &expires_in_seconds);
     }
+    VLOG(1) << "Gaia response: acess_token='" << access_token
+            << "', refresh_token='" << refresh_token
+            << "', expires in " << expires_in_seconds << " second(s)";
+  } else {
+    VLOG(1) << "Gaia response: response code=" << source->GetResponseCode();

[Jamie, 2012/04/12 18:20:20]

Also LOG(ERROR), just for the "else" clause.

   }
   if (access_token.empty()) {
     // If we don't have an access token yet and the the error was not
     // RC_BAD_REQUEST, we may need to retry.
     if ((-1 != source->GetMaxRetries()) &&
         (num_retries_ > source->GetMaxRetries())) {
       // Retry limit reached. Give up.
       delegate_->OnNetworkError(source->GetResponseCode());
     } else {
       *should_retry_request = true;
@@ skipping 32 matching lines @@
                                    const std::string& refresh_token,
                                    int max_retries,
                                    Delegate* delegate) {
   return core_->RefreshToken(oauth_client_info,
                              refresh_token,
                              max_retries,
                              delegate);
 }
 
 }  // namespace remoting