Issue 10069007: Media Gallery: Move MediaDeviceNotificationsLinux from content to chrome.

Issue 10069007: Media Gallery: Move MediaDeviceNotificationsLinux from content to chrome. (Closed)

Created:
8 years, 8 months ago by Lei Zhang

Modified:
8 years, 8 months ago

Reviewers:
vandebo (ex-Chrome), jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Media Gallery: Move MediaDeviceNotificationsLinux from content to chrome. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132087

Patch Set 2 : fix checkdeps error #

Patch Set 4 : clang #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -815 lines)			Patch
M	chrome/browser/chrome_browser_main_linux.h	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_linux.cc	View	1 2 3	3 chunks	+10 lines, -0 lines	0 comments	Download
A +	chrome/browser/media_gallery/media_device_notifications_linux.h	View		3 chunks	+6 lines, -7 lines	0 comments	Download
A +	chrome/browser/media_gallery/media_device_notifications_linux.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
A +	chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/browser_main_loop.h	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	1 2	2 chunks	+0 lines, -12 lines	0 comments	Download
D	content/browser/media_device_notifications_linux.h	View	1 2	1 chunk	+0 lines, -106 lines	0 comments	Download
D	content/browser/media_device_notifications_linux.cc	View	1 2	1 chunk	+0 lines, -278 lines	0 comments	Download
D	content/browser/media_device_notifications_linux_unittest.cc	View	1 2	1 chunk	+0 lines, -396 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with one change what about the windows stuff, is that in a future change? ...

8 years, 8 months ago (2012-04-12 16:20:38 UTC) #2

Lei Zhang

https://chromiumcodereview.appspot.com/10069007/diff/3003/chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc File chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc (right): https://chromiumcodereview.appspot.com/10069007/diff/3003/chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc#newcode21 chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc:21: #include "content/browser/browser_thread_impl.h" On 2012/04/12 16:20:38, John Abd-El-Malek wrote: > ...

8 years, 8 months ago (2012-04-12 20:38:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10069007/1017

8 years, 8 months ago (2012-04-12 20:38:41 UTC) #4

commit-bot: I haz the power

Can't apply patch for file chrome/browser/media_gallery/media_device_notifications_linux.cc. While running patch -p0 --forward --force; patching file chrome/browser/media_gallery/media_device_notifications_linux.cc ...

8 years, 8 months ago (2012-04-12 20:39:04 UTC) #5

Lei Zhang

8 years, 8 months ago (2012-04-12 23:35:03 UTC) #6

On 2012/04/12 16:20:38, John Abd-El-Malek wrote:
> what about the windows stuff, is that in a future change?

tpayne@ is working on that.

Expand Messages | Collapse Messages