Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 10068012: MIPS: Improve performance of keyed loads/stores which have a HeapNumber index. (Closed)

Created:
8 years, 8 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Improve performance of keyed loads/stores which have a HeapNumber index. Port r11282 (bd2ab07). Patch by Daniel Kalmar. Original commit message: Some GWT compiled code results in array access that has a heap number (e.g. -0) as an index. Until now this would result in a generic IC. For example: a[-0] === a[0] or a[0.25 * 4] === a[1] This change detects heap numbers that are representable as a smi and converts them. As a result we can still use the fast keyed monomorphic ICs. Optimized code already handles keyed access with a double-key efficiently. As a result the frame rate on the reported benchmark improves by roughly 2x. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -12 lines) Patch
M src/mips/stub-cache-mips.cc View 7 chunks +52 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kalmard
8 years, 8 months ago (2012-04-12 12:10:48 UTC) #1
fschneider
LGTM. Thanks for the patch. I'll land it.
8 years, 8 months ago (2012-04-13 07:45:17 UTC) #2
fschneider
8 years, 8 months ago (2012-04-13 13:05:11 UTC) #3
On 2012/04/13 07:45:17, fschneider wrote:
> LGTM.
> 
> Thanks for the patch. I'll land it.

Landed in r11318.

Powered by Google App Engine
This is Rietveld 408576698