Implement Content Security Policy for the File Manager

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Setting the src of an img to an empty string can crash the browser, so we
 // use an empty 1x1 gif instead.
 
 /**
  * FileManager constructor.
  *
@@ skipping 614 matching lines @@
   };
 
   /**
    * One-time initialization of various DOM nodes.
    */
   FileManager.prototype.initDom_ = function() {
     // Cache nodes we'll be manipulating.
     this.previewThumbnails_ =
         this.dialogDom_.querySelector('.preview-thumbnails');
     this.previewPanel_ = this.dialogDom_.querySelector('.preview-panel');
-    this.previewFilename_ = this.dialogDom_.querySelector('.preview-filename');
     this.previewSummary_ = this.dialogDom_.querySelector('.preview-summary');
     this.filenameInput_ = this.dialogDom_.querySelector('.filename-input');
     this.taskItems_ = this.dialogDom_.querySelector('.tasks');
     this.okButton_ = this.dialogDom_.querySelector('.ok');
     this.cancelButton_ = this.dialogDom_.querySelector('.cancel');
     this.deleteButton_ = this.dialogDom_.querySelector('.delete-button');
     this.table_ = this.dialogDom_.querySelector('.detail-table');
     this.grid_ = this.dialogDom_.querySelector('.thumbnail-grid');
     this.spinner_ = this.dialogDom_.querySelector('.spinner');
     this.showSpinner_(false);
@@ skipping 30 matching lines @@
         'keyup', this.onFilenameInputKeyUp_.bind(this));
     this.filenameInput_.addEventListener(
         'focus', this.onFilenameInputFocus_.bind(this));
 
     var listContainer = this.dialogDom_.querySelector('.list-container');
     listContainer.addEventListener('keydown', this.onListKeyDown_.bind(this));
     listContainer.addEventListener('keypress', this.onListKeyPress_.bind(this));
     this.okButton_.addEventListener('click', this.onOk_.bind(this));
     this.cancelButton_.addEventListener('click', this.onCancel_.bind(this));
 
+    this.deleteButton_.addEventListener('click',
+        this.onDeleteButtonClick_.bind(this));
+    this.deleteButton_.addEventListener('keypress',
+        this.onDeleteButtonKeyPress_.bind(this));
+
     this.dialogDom_.querySelector('div.open-sidebar').addEventListener(
         'click', this.onToggleSidebar_.bind(this));
     this.dialogDom_.querySelector('div.open-sidebar').addEventListener(
         'keypress', this.onToggleSidebarPress_.bind(this));
     this.dialogDom_.querySelector('div.close-sidebar').addEventListener(
         'click', this.onToggleSidebar_.bind(this));
     this.dialogDom_.querySelector('div.close-sidebar').addEventListener(
         'keypress', this.onToggleSidebarPress_.bind(this));
     this.dialogContainer_ = this.dialogDom_.querySelector('.dialog-container');
     this.dialogDom_.querySelector('div.detail-view').addEventListener(
@@ skipping 18 matching lines @@
         }.bind(this)
     );
 
     cr.ui.ComboButton.decorate(this.taskItems_);
     this.taskItems_.addEventListener('select',
         this.onTaskItemClicked_.bind(this));
 
     this.dialogDom_.ownerDocument.defaultView.addEventListener(
         'resize', this.onResize_.bind(this));
 
-    var ary = this.dialogDom_.querySelectorAll('[visibleif]');
-    for (var i = 0; i < ary.length; i++) {
-      var expr = ary[i].getAttribute('visibleif');
-      if (!eval(expr))
-        ary[i].style.display = 'none';
-    }
+    this.dialogDom_.setAttribute('type', this.dialogType_);

[dgozman, 2012/04/12 11:18:14]

I believe, we have a method initDialogType.

[Vladislav Kaznacheev, 2012/04/12 12:47:32]

Done.

+    if (str('ASH') == '1')
+      this.dialogDom_.setAttribute('ash', true);

[dgozman, 2012/04/12 11:18:14]

true -> 'true' ?

[Vladislav Kaznacheev, 2012/04/12 12:47:32]

Done.

 
     this.filePopup_ = null;
 
     // Populate the static localized strings.
     i18nTemplate.process(this.document_, localStrings.templateData);
   };
 
   /**
    * Constructs table and grid (heavy operation).
    **/
@@ skipping 2556 matching lines @@
       }
 
       this.confirm.show(msg, this.deleteEntries.bind(
           this, entries, true, opt_callback));
       return;
     }
 
     this.directoryModel_.deleteEntries(entries, opt_callback);
   };
 
+  FileManager.prototype.onDeleteButtonClick_ = function() {
+    this.deleteEntries(this.selection.entries);
+  },
+
+  FileManager.prototype.onDeleteButtonKeyPress_ = function(event) {
+    switch (util.getKeyModifiers(event) + event.keyCode) {
+      case '13':  // Enter
+      case '32':  // Space
+        this.deleteEntries(this.selection.entries);

[dgozman, 2012/04/12 11:18:14]

also event.preventDefault and event.stopPropagation.

[Vladislav Kaznacheev, 2012/04/12 12:47:32]

Done.

+        break;
+    }
+  },
+
   FileManager.prototype.blinkSelection = function() {
     if (!this.selection || this.selection.totalCount == 0)
       return;
 
     for (var i = 0; i < this.selection.entries.length; i++) {
       var selectedIndex = this.selection.indexes[i];
       var listItem = this.currentList_.getListItemByIndex(selectedIndex);
       if (listItem)
         this.blinkListItem_(listItem);
     }
@@ skipping 1381 matching lines @@
 
     chrome.fileBrowserPrivate.setGDataPreferences(changeInfo);
 
     if (oldValue) {
       event.target.removeAttribute('checked');
     } else {
       event.target.setAttribute('checked', 'checked');
     }
   };
 })();