Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: media/filters/video_renderer_base.cc

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/video/capture/video_capture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_renderer_base.cc
diff --git a/media/filters/video_renderer_base.cc b/media/filters/video_renderer_base.cc
index e3a5fe0ac7f44d313950eccaf932a9acbecf936c..b0672f540bc80b1178537e65a5108812cd5450d7 100644
--- a/media/filters/video_renderer_base.cc
+++ b/media/filters/video_renderer_base.cc
@@ -31,11 +31,6 @@ VideoRendererBase::VideoRendererBase(const base::Closure& paint_cb,
DCHECK(!paint_cb_.is_null());
}
-VideoRendererBase::~VideoRendererBase() {
- base::AutoLock auto_lock(lock_);
- DCHECK(state_ == kUninitialized || state_ == kStopped) << state_;
-}
-
void VideoRendererBase::Play(const base::Closure& callback) {
base::AutoLock auto_lock(lock_);
DCHECK_EQ(kPrerolled, state_);
@@ -358,6 +353,11 @@ void VideoRendererBase::PutCurrentFrame(scoped_refptr<VideoFrame> frame) {
}
}
+VideoRendererBase::~VideoRendererBase() {
+ base::AutoLock auto_lock(lock_);
+ DCHECK(state_ == kUninitialized || state_ == kStopped) << state_;
+}
+
void VideoRendererBase::FrameReady(VideoDecoder::DecoderStatus status,
scoped_refptr<VideoFrame> frame) {
base::AutoLock auto_lock(lock_);
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/video/capture/video_capture.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698