Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 10067035: RefCounted types should not have public destructors, media/ and gpu/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/query_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index 4680a378566958dddd80aa3c564b52abec3fd377..7ed551b78c337aa36caf296a378e2ebf9c746c15 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -17,8 +17,6 @@ class RenderbufferAttachment
: renderbuffer_(renderbuffer) {
}
- virtual ~RenderbufferAttachment() { }
-
virtual GLsizei width() const {
return renderbuffer_->width();
}
@@ -73,6 +71,9 @@ class RenderbufferAttachment
return renderbuffer_.get();
}
+ protected:
+ virtual ~RenderbufferAttachment() { }
+
private:
RenderbufferManager::RenderbufferInfo::Ref renderbuffer_;
@@ -89,8 +90,6 @@ class TextureAttachment
level_(level) {
}
- virtual ~TextureAttachment() { }
-
virtual GLsizei width() const {
GLsizei temp_width = 0;
GLsizei temp_height = 0;
@@ -159,6 +158,9 @@ class TextureAttachment
return (need & have) != 0;
}
+ protected:
+ virtual ~TextureAttachment() { }
+
private:
TextureManager::TextureInfo::Ref texture_;
GLenum target_;
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/query_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698