Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Issue 10067030: Upgrade the history database to version 23 (Closed)

Created:
8 years, 8 months ago by michaelbai
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Upgrade the history database to version 23 - Android_urls table data schema was changed. - Migrate the data to new table. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133008

Patch Set 1 : Init #

Total comments: 2

Patch Set 2 : Remove 'if not exists' #

Patch Set 3 : Update the test history database #

Patch Set 4 : Sync and update test data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
M chrome/browser/history/android/android_urls_database.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/history/android/android_urls_database.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/history/android/android_urls_database_unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/browser/history/history_database.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/History/history.21.sql View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/profiles/typical_history/Default/History View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaelbai
8 years, 8 months ago (2012-04-13 20:12:19 UTC) #1
sky
http://codereview.chromium.org/10067030/diff/1009/chrome/browser/history/android/android_urls_database.cc File chrome/browser/history/android/android_urls_database.cc (right): http://codereview.chromium.org/10067030/diff/1009/chrome/browser/history/android/android_urls_database.cc#newcode21 chrome/browser/history/android/android_urls_database.cc:21: sql.append("CREATE TABLE IF NOT EXISTS "); How come you ...
8 years, 8 months ago (2012-04-13 21:32:05 UTC) #2
michaelbai
Synced code, PTAL http://codereview.chromium.org/10067030/diff/1009/chrome/browser/history/android/android_urls_database.cc File chrome/browser/history/android/android_urls_database.cc (right): http://codereview.chromium.org/10067030/diff/1009/chrome/browser/history/android/android_urls_database.cc#newcode21 chrome/browser/history/android/android_urls_database.cc:21: sql.append("CREATE TABLE IF NOT EXISTS "); ...
8 years, 8 months ago (2012-04-13 23:02:35 UTC) #3
sky
LGTM
8 years, 8 months ago (2012-04-13 23:26:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10067030/5001
8 years, 8 months ago (2012-04-13 23:32:28 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 00:27:48 UTC) #6
Try job failure for 10067030-5001 (retry) on linux_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698