Issue 10067026: Accomodate files larger than maxint in size in blob/file reading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10067026: Accomodate files larger than maxint in size in blob/file reading. (Closed)

Created:
8 years, 8 months ago by michaeln

Modified:
8 years, 8 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Accomodate files larger than maxint in size in blob/file reading. BUG=114179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132244

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	webkit/blob/blob_url_request_job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/blob/blob_url_request_job.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/blob/local_file_reader.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/blob/local_file_reader.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kinuko

8 years, 8 months ago (2012-04-13 02:50:10 UTC) #2

On 2012/04/13 01:12:44, michaeln wrote:
> hi kinuko, this fixes crbug/114179

lgtm

Yep, last night I noticed it and wanted to fix like this.  Thanks!

Expand Messages | Collapse Messages