Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: chrome/browser/ui/panels/display_settings_provider.cc

Issue 10066041: Revert 132144 - Broke ASAN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/display_settings_provider.h" 5 #include "chrome/browser/ui/panels/display_settings_provider.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/browser/fullscreen.h"
9 #include "ui/gfx/screen.h" 8 #include "ui/gfx/screen.h"
10 9
11 namespace {
12 // The polling interval to check any display settings change, like full-screen
13 // mode changes.
14 const int kFullScreenModeCheckIntervalMs = 1000;
15 } // namespace
16
17 DisplaySettingsProvider::DisplaySettingsProvider() 10 DisplaySettingsProvider::DisplaySettingsProvider()
18 : is_full_screen_(false) { 11 : display_area_observer_(NULL),
12 desktop_bar_observer_(NULL) {
19 } 13 }
20 14
21 DisplaySettingsProvider::~DisplaySettingsProvider() { 15 DisplaySettingsProvider::~DisplaySettingsProvider() {
22 } 16 }
23 17
24 void DisplaySettingsProvider::AddDisplayAreaObserver(
25 DisplayAreaObserver* observer) {
26 display_area_observers_.AddObserver(observer);
27 }
28
29 void DisplaySettingsProvider::RemoveDisplayAreaObserver(
30 DisplayAreaObserver* observer) {
31 display_area_observers_.RemoveObserver(observer);
32 }
33
34 void DisplaySettingsProvider::AddDesktopBarObserver(
35 DesktopBarObserver* observer) {
36 desktop_bar_observers_.AddObserver(observer);
37 }
38
39 void DisplaySettingsProvider::RemoveDesktopBarObserver(
40 DesktopBarObserver* observer) {
41 desktop_bar_observers_.RemoveObserver(observer);
42 }
43
44 void DisplaySettingsProvider::AddFullScreenObserver(
45 FullScreenObserver* observer) {
46 full_screen_observers_.AddObserver(observer);
47
48 if (full_screen_observers_.size() == 1) {
49 full_screen_mode_timer_.Start(FROM_HERE,
50 base::TimeDelta::FromMilliseconds(kFullScreenModeCheckIntervalMs),
51 this, &DisplaySettingsProvider::CheckFullScreenMode);
52 }
53 }
54
55 void DisplaySettingsProvider::RemoveFullScreenObserver(
56 FullScreenObserver* observer) {
57 full_screen_observers_.RemoveObserver(observer);
58
59 if (full_screen_observers_.size() == 0)
60 full_screen_mode_timer_.Stop();
61 }
62
63 gfx::Rect DisplaySettingsProvider::GetDisplayArea() { 18 gfx::Rect DisplaySettingsProvider::GetDisplayArea() {
64 // Do the first-time initialization if not yet. 19 // Do the first-time initialization if not yet.
65 if (adjusted_work_area_.IsEmpty()) 20 if (adjusted_work_area_.IsEmpty())
66 OnDisplaySettingsChanged(); 21 OnDisplaySettingsChanged();
67 22
68 return adjusted_work_area_; 23 return adjusted_work_area_;
69 } 24 }
70 25
71 gfx::Rect DisplaySettingsProvider::GetWorkArea() const { 26 gfx::Rect DisplaySettingsProvider::GetWorkArea() const {
72 #if defined(OS_MACOSX) 27 #if defined(OS_MACOSX)
(...skipping 12 matching lines...) Expand all
85 return; 40 return;
86 work_area_ = work_area; 41 work_area_ = work_area;
87 42
88 OnAutoHidingDesktopBarChanged(); 43 OnAutoHidingDesktopBarChanged();
89 } 44 }
90 45
91 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() { 46 void DisplaySettingsProvider::OnAutoHidingDesktopBarChanged() {
92 gfx::Rect old_adjusted_work_area = adjusted_work_area_; 47 gfx::Rect old_adjusted_work_area = adjusted_work_area_;
93 AdjustWorkAreaForAutoHidingDesktopBars(); 48 AdjustWorkAreaForAutoHidingDesktopBars();
94 49
95 if (old_adjusted_work_area != adjusted_work_area_) { 50 if (old_adjusted_work_area != adjusted_work_area_ && display_area_observer_)
96 FOR_EACH_OBSERVER(DisplayAreaObserver, 51 display_area_observer_->OnDisplayAreaChanged(adjusted_work_area_);
97 display_area_observers_,
98 OnDisplayAreaChanged(adjusted_work_area_));
99 }
100 } 52 }
101 53
102 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled( 54 bool DisplaySettingsProvider::IsAutoHidingDesktopBarEnabled(
103 DesktopBarAlignment alignment) { 55 DesktopBarAlignment alignment) {
104 return false; 56 return false;
105 } 57 }
106 58
107 int DisplaySettingsProvider::GetDesktopBarThickness( 59 int DisplaySettingsProvider::GetDesktopBarThickness(
108 DesktopBarAlignment alignment) const { 60 DesktopBarAlignment alignment) const {
109 return 0; 61 return 0;
(...skipping 18 matching lines...) Expand all
128 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 80 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
129 } 81 }
130 if (IsAutoHidingDesktopBarEnabled( 82 if (IsAutoHidingDesktopBarEnabled(
131 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) { 83 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT)) {
132 int space = GetDesktopBarThickness( 84 int space = GetDesktopBarThickness(
133 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT); 85 DisplaySettingsProvider::DESKTOP_BAR_ALIGNED_RIGHT);
134 adjusted_work_area_.set_width(adjusted_work_area_.width() - space); 86 adjusted_work_area_.set_width(adjusted_work_area_.width() - space);
135 } 87 }
136 } 88 }
137 89
138 void DisplaySettingsProvider::CheckFullScreenMode() {
139 bool is_full_screen = IsFullScreenMode();
140 if (is_full_screen == is_full_screen_)
141 return;
142 is_full_screen_ = is_full_screen;
143
144 FOR_EACH_OBSERVER(FullScreenObserver,
145 full_screen_observers_,
146 OnFullScreenModeChanged(is_full_screen_));
147 }
148
149 #if defined(USE_AURA) 90 #if defined(USE_AURA)
150 // static 91 // static
151 DisplaySettingsProvider* DisplaySettingsProvider::Create() { 92 DisplaySettingsProvider* DisplaySettingsProvider::Create() {
152 return new DisplaySettingsProvider(); 93 return new DisplaySettingsProvider();
153 } 94 }
154 #endif 95 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/display_settings_provider.h ('k') | chrome/browser/ui/panels/display_settings_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698